tracing fixes
All checks were successful
continuous-integration/drone/push Build is passing

This commit is contained in:
Pünkösd Marcell 2021-08-04 15:20:29 +02:00
parent 977fc98ed2
commit ee9dea06fb
3 changed files with 34 additions and 30 deletions

View File

@ -29,8 +29,12 @@ class Classifier(object):
@staticmethod @staticmethod
def create_spectrogram(wav_filename: str) -> Tuple[str, str]: def create_spectrogram(wav_filename: str) -> Tuple[str, str]:
matplotlib.pyplot.interactive(False)
with opentracing.tracer.start_active_span('classifier.librosa.load'):
clip, sample_rate = librosa.load(wav_filename, sr=None) clip, sample_rate = librosa.load(wav_filename, sr=None)
with opentracing.tracer.start_active_span('classifier.Plot'):
matplotlib.pyplot.interactive(False)
fig = matplotlib.pyplot.figure(figsize=[0.72, 0.72]) fig = matplotlib.pyplot.figure(figsize=[0.72, 0.72])
ax = fig.add_subplot(111) ax = fig.add_subplot(111)
ax.axes.get_xaxis().set_visible(False) ax.axes.get_xaxis().set_visible(False)
@ -85,12 +89,10 @@ class Classifier(object):
return predicted_class_name, labeled_predictions return predicted_class_name, labeled_predictions
def predict(self, wav_filename: str) -> Tuple[str, dict]: def predict(self, wav_filename: str) -> Tuple[str, dict]:
span = opentracing.tracer.scope_manager.active().span with opentracing.tracer.start_active_span('classifier.createSpectrogram'):
with opentracing.tracer.start_active_span('createSpectrogram', child_of=span):
directory, _ = self.create_spectrogram(wav_filename) directory, _ = self.create_spectrogram(wav_filename)
with opentracing.tracer.start_active_span('runPredictor', child_of=span): with opentracing.tracer.start_active_span('classifier.runPredictor'):
result = self._run_predictor(directory) result = self._run_predictor(directory)
shutil.rmtree(directory) # The image is no longer needed shutil.rmtree(directory) # The image is no longer needed

View File

@ -19,15 +19,16 @@ class MagicDoer:
@classmethod @classmethod
def run_everything(cls, parameters: dict) -> dict: def run_everything(cls, parameters: dict) -> dict:
span = opentracing.tracer.scope_manager.active().span
tag = parameters['tag'] tag = parameters['tag']
sample_file_handle, sample_file_path = tempfile.mkstemp(prefix=f"{tag}_", suffix=".wav", dir="/dev/shm") sample_file_handle, sample_file_path = tempfile.mkstemp(prefix=f"{tag}_", suffix=".wav", dir="/dev/shm")
span = opentracing.tracer.scope_manager.active().span
span.log_kv({'event': 'sampleFileOpened', 'sampleTag': tag}) span.log_kv({'event': 'sampleFileOpened', 'sampleTag': tag})
response = None response = None
try: try:
with opentracing.tracer.start_active_span('downloadSample', child_of=span): with opentracing.tracer.start_active_span('magicDoer.downloadSample'):
# Download Sample # Download Sample
object_path = urljoin(Config.STORAGE_SERVICE_URL, f"object/{tag}") object_path = urljoin(Config.STORAGE_SERVICE_URL, f"object/{tag}")
@ -38,11 +39,11 @@ class MagicDoer:
logging.debug(f"Downloaded sample to {sample_file_path}") logging.debug(f"Downloaded sample to {sample_file_path}")
with opentracing.tracer.start_active_span('loadClassifier', child_of=span): with opentracing.tracer.start_active_span('magicDoer.getClassifier'):
# Get a classifier that uses the default model # Get a classifier that uses the default model
model_details, classifier = cls.classifier_cache.get_default_classifier() model_details, classifier = cls.classifier_cache.get_default_classifier()
with opentracing.tracer.start_active_span('runClassifier', child_of=span) as child_span: with opentracing.tracer.start_active_span('magicDoer.runClassifier'):
# do the majic # do the majic
classification_start_time = time.time() classification_start_time = time.time()
predicted_class_name, labeled_predictions = classifier.predict(sample_file_path) predicted_class_name, labeled_predictions = classifier.predict(sample_file_path)
@ -63,6 +64,7 @@ class MagicDoer:
except FileNotFoundError: except FileNotFoundError:
pass pass
span = opentracing.tracer.scope_manager.active().span
span.log_kv({'event': 'sampleFileDeleted', 'sampleTag': tag}) span.log_kv({'event': 'sampleFileDeleted', 'sampleTag': tag})
if not response: if not response:

View File

@ -19,16 +19,16 @@ from magic_doer import MagicDoer
def message_callback(channel, method, properties, body): def message_callback(channel, method, properties, body):
with opentracing.tracer.start_active_span('messageHandling', finish_on_close=True) as span: with opentracing.tracer.start_active_span('main.handleMessage', finish_on_close=True) as scope:
try: try:
msg = json.loads(body.decode('utf-8')) msg = json.loads(body.decode('utf-8'))
except (UnicodeDecodeError, json.JSONDecodeError) as e: except (UnicodeDecodeError, json.JSONDecodeError) as e:
logging.warning(f"Invalid message recieved: {e}") logging.warning(f"Invalid message recieved: {e}")
return return
span.log_kv({'event': 'messageParsed', 'sampleTag': msg['tag']}) scope.span.log_kv({'event': 'messageParsed', 'sampleTag': msg['tag']})
with opentracing.tracer.start_active_span('runAlgorithm', child_of=span) as child_span: with opentracing.tracer.start_active_span('magicDoer.run_everything'):
results = MagicDoer.run_everything(msg) # <- This is where the magic happens results = MagicDoer.run_everything(msg) # <- This is where the magic happens
if results: if results: