From 1292a125b867e38c5f662ed1224c8731934c9240 Mon Sep 17 00:00:00 2001 From: Burak Yigit Kaya Date: Tue, 21 Jan 2020 22:56:45 +0300 Subject: [PATCH] =?UTF-8?q?fix(install):=20Remove=20unnecessary=20infinite?= =?UTF-8?q?=20loop=20from=20snuba=20bootst=E2=80=A6=20(#354)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With getsentry/snuba#709 merged, we no longer need to randomly try forever creating Kafka topics, which were a prerequisite for creating Clickhouse tables. This patch also removes the preceding (and obsolete) `docker-compose up` statement which was used to "speed up" the `snuba bootstrap` command in the hopes to fix it. --- install.sh | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/install.sh b/install.sh index 01d8a34..de1f6ad 100755 --- a/install.sh +++ b/install.sh @@ -104,13 +104,10 @@ echo "" echo "Docker images built." echo "Bootstrapping Snuba..." -$dc up -d kafka redis clickhouse -until $($dcr clickhouse clickhouse-client -h clickhouse --query="SHOW TABLES;" | grep -q sentry_local); do - # `bootstrap` is for fresh installs, and `migrate` is for existing installs - # Running them both for both cases is harmless so we blindly run them - $dcr snuba-api bootstrap --force || true; - $dcr snuba-api migrate || true; -done; +# `bootstrap` is for fresh installs, and `migrate` is for existing installs +# Running them both for both cases is harmless so we blindly run them +$dcr snuba-api bootstrap --force +$dcr snuba-api migrate echo "" # Very naively check whether there's an existing sentry-postgres volume and the PG version in it