more oop

src/resources/itemapi.py

@@ -7,14 +7,13 @@ __copyright__ = "Copyright 2020, onSpot Team"
 __module_name__ = "itemapi"
 __version__text__ = "1"
 
-import musicbrainzngs
 from flask import request, current_app, abort
 
 from flaskaddons.fred import flaskred
-from resources.spotifyuserstoreresource import SpotifyUserStoreResource
+from resources.apiinteractionresource import APIInteractionResource
 
 
-class ItemApi(SpotifyUserStoreResource):
+class ItemApi(APIInteractionResource):
     """
     See: https://swagger.kmlabz.com/?urls.primaryName=onSpot%20Backend#/backend/getItem
     """
@@ -23,7 +22,7 @@ class ItemApi(SpotifyUserStoreResource):
         try:
             flaskred.get(request.headers.get('Authorization')).decode('UTF-8')
         except Exception as e:
-            current_app.logger.warning(e)
+            current_app.logger.info(e)
             abort(401, "unauthorized")
         try:
             item_type = flaskred.get(itemid).decode('UTF-8')
@@ -32,69 +31,12 @@ class ItemApi(SpotifyUserStoreResource):
             abort(404, "unknown item")
 
         if item_type == 'release':
-            currrelease = musicbrainzngs.get_release_by_id(itemid, includes=['artists'])['release']
-            retdata = {"id": itemid, "album": currrelease['title']}
-            if 'artist-credit' in currrelease and currrelease['artist-credit']:
-                retdata['artist'] = currrelease['artist-credit'][0]['artist']['name']
-            album_spot = \
-                self.spotify.search(q=f"{retdata.get('artist', '')} {retdata['album']}", limit=1).get(
-                    'albums')
-            if album_spot:
-                album_spot = album_spot['items']
-                if album_spot:
-                    retdata['spotify_id'] = f"spotify:album:{album_spot[0]['id']}"
-            try:
-                imgurl = musicbrainzngs.get_image_list(currrelease['id'])['images']
-                if imgurl:
-                    retdata['cover_url_small'] = imgurl[0]['thumbnails']['small']
-                    retdata['cover_url'] = imgurl[0]['thumbnails']['large']
-            except Exception as e:
-                current_app.logger.warning(e)
-            if album_spot:
-                retdata['spotify_id'] = f"spotify:album:{album_spot[0]['id']}"
+            return self.getreleaseinfo(itemid), 200
         elif item_type == 'artist':
-            currartist = musicbrainzngs.get_artist_by_id(itemid)['artist']
-            artist_spot = self.spotify.search(q=currartist['name'], type="artist", limit=1)['artists']['items']
-            retdata = {"id": itemid, "artist": currartist['name']}
-            if artist_spot:
-                retdata['spotify_id'] = f"spotify:artist:{artist_spot[0]['id']}"
-                artist_image = artist_spot[0]['images']
-                if artist_image:
-                    retdata['cover_url'] = artist_image[0]['url']
-                    retdata['cover_url_small'] = artist_image[len(artist_image) - 1]['url']
+            return self.getartistinfo(itemid), 200
         elif item_type == 'work':
-            currwork = musicbrainzngs.get_work_by_id(itemid)['work']
-            work_spot = self.spotify.search(q=currwork['title'], type="track", limit=1)['tracks']['items']
-            retdata = {"id": itemid, "title": currwork['title']}
-            if work_spot:
-                retdata['spotify_id'] = f"spotify:track:{work_spot[0]['id']}"
-                work_image = work_spot[0]['album']['images']
-                if work_image:
-                    retdata['cover_url'] = work_image[0]['url']
-                    retdata['cover_url_small'] = work_image[len(work_image) - 1]['url']
+            return self.getworkinfo(itemid), 200
         elif item_type == 'recording':
-            currrecording = musicbrainzngs.get_recording_by_id(itemid, includes=['artists', 'releases'])['recording']
-            retdata = {"id": itemid, "title": currrecording['title']}
-            if 'artist-credit' in currrecording and currrecording['artist-credit']:
-                currartist = currrecording['artist-credit'][0]['artist']
-                retdata['artist'] = currartist['name']
-            if 'release-list' in currrecording and currrecording['release-list']:
-                currrlease = currrecording['release-list'][0]
-                retdata['album'] = currrlease['title']
-                try:
-                    imgurl = musicbrainzngs.get_image_list(currrlease['id'])['images']
-                    if imgurl:
-                        retdata['cover_url_small'] = imgurl[0]['thumbnails']['small']
-                        retdata['cover_url'] = imgurl[0]['thumbnails']['large']
-                except Exception as e:
-                    current_app.logger.warning(e)
-            recording_spot = \
-                self.spotify.search(q=f"{retdata.get('artist', '')} {retdata.get('album', '')} {retdata['title']}",
-                                    limit=1)['tracks']['items']
-            if recording_spot:
-                retdata['spotify_id'] = f"spotify:track:{recording_spot[0]['id']}"
+            return self.getrecordinginfo(itemid), 200
         else:
             abort(417, "wrong type of item")
-
-        retdata['type'] = item_type
-        return retdata, 200