.drone.yml

@@ -1,30 +0,0 @@
-kind: pipeline
-type: docker
-name: default
-steps:
-  - name: build-image
-    image: docker:dind
-    volumes:
-      - name: dockersock
-        path: /var/run
-    environment:
-      DOCKER_USERNAME:
-        from_secret: DOCKER_USERNAME
-      DOCKER_PASSWORD:
-        from_secret: DOCKER_PASSWORD
-    commands:
-      - sleep 10
-      - echo "$DOCKER_PASSWORD" | docker login --username "$DOCKER_USERNAME" --password-stdin registry.kmlabz.com
-      - docker build -t registry.kmlabz.com/tormakris/drone-kaniko .
-      - docker push registry.kmlabz.com/tormakris/drone-kaniko
-
-services:
-- name: docker
-  image: docker:dind
-  privileged: true
-  volumes:
-  - name: dockersock
-    path: /var/run
-volumes:
-- name: dockersock
-  temp: {}

Dockerfile

@@ -1,4 +1,4 @@
-FROM gcr.io/kaniko-project/executor:debug
+FROM gcr.io/kaniko-project/executor:debug-v0.7.0
 
 ENV HOME /root
 ENV USER root

README.md

@@ -2,7 +2,7 @@
 
 A thin shim-wrapper around the official [Google Kaniko](https://cloud.google.com/blog/products/gcp/introducing-kaniko-build-container-images-in-kubernetes-and-google-container-builder-even-without-root-access) Docker image to make it behave like the [Drone Docker plugin](http://plugins.drone.io/drone-plugins/drone-docker/).
 
-Example .drone.yml for Drone 1.0 (pushing to Docker Hub):
+Example .drone.yml for Drone 1.0
 
 ```yaml
 kind: pipeline
@@ -12,11 +12,10 @@ steps:
 - name: publish
   image: banzaicloud/drone-kaniko
   settings:
-    registry: registry.example.com # if not provided index.docker.io is supposed
+    registry: registry.example.com
     repo: registry.example.com/example-project
     tags: ${DRONE_COMMIT_SHA}
     cache: true
-    skip_tls_verify: false # set to true for testing registries ONLY with self-signed certs
     build_args:
     - COMMIT_SHA=${DRONE_COMMIT_SHA}
     - COMMIT_AUTHOR_EMAIL=${DRONE_COMMIT_AUTHOR_EMAIL}
@@ -26,80 +25,6 @@ steps:
       from_secret: docker-password
 ```
 
-Pushing to GCR:
-
-```yaml
-kind: pipeline
-name: default
-
-steps:
-- name: publish
-  image: banzaicloud/drone-kaniko
-  settings:
-    registry: gcr.io
-    repo: example.com/example-project
-    tags: ${DRONE_COMMIT_SHA}
-    cache: true
-    json_key:
-      from_secret: google-application-credentials
-```
-
-## Use `.tags` file for tagging
-
-Similarily to official
-[drone-docker](https://github.com/drone-plugins/drone-docker) plugin you can use
-`.tags` file to embed some custom logic for creating tags for an image.
-
-```yaml
-kind: pipeline
-name: default
-
-steps:
-- name: build
-  image: golang
-  commands:
-      - go get 
-      - go build
-      - make versiontags > .tags
-- name: publish
-  image: banzaicloud/drone-kaniko
-  settings:
-    registry: registry.example.com 
-    repo: registry.example.com/example-project
-    # tags: ${DRONE_COMMIT_SHA} <= it must be left undefined 
-    username:
-      from_secret: docker-username
-    password:
-      from_secret: docker-password
-```
-
-## Auto tag
-
-Set `auto_tag: true`.
-
-```yaml
-kind: pipeline
-name: default
-
-steps:
-- name: build
-  image: golang
-  commands:
-      - go get 
-      - go build
-- name: publish
-  image: banzaicloud/drone-kaniko
-  settings:
-    registry: registry.example.com 
-    repo: registry.example.com/example-project
-    auto_tag: true # higher priority then .tags file
-    # tags: ${DRONE_COMMIT_SHA} <= it must be left undefined to use auto_tag
-    username:
-      from_secret: docker-username
-    password:
-      from_secret: docker-password
-```
-
 ## Test that it can build
 
 ```bash
@@ -129,18 +54,12 @@ docker build -t banzaicloud/drone-kaniko .
 Warm up the alpine image to the cache:
 
 ```bash
-docker run -v $PWD:/cache gcr.io/kaniko-project/warmer:latest --verbosity=debug --image=alpine:3.8
+docker run -v $PWD:/cache gcr.io/kaniko-project/warmer:latest --image=alpine:3.8
 ```
 
 
-Run the builder (on the host network to be able to access the registry, if any specified) with mounting the local disk cache, this example pushes to Docker Hub:
+Run the builder on the host network to be able to access the registry:
 
 ```bash
-docker run --net=host -it --rm -w /src -v $PWD:/cache -v $PWD:/src -e PLUGIN_USERNAME=${DOCKER_USERNAME} -e PLUGIN_PASSWORD=${DOCKER_PASSWORD} -e PLUGIN_REPO=banzaicloud/drone-kaniko-test -e PLUGIN_TAGS=test -e PLUGIN_DOCKERFILE=Dockerfile.test -e PLUGIN_CACHE=true banzaicloud/drone-kaniko
+docker run --net=host -it --rm -w /src -v $PWD:/cache -v $PWD:/src -e DOCKER_USERNAME=${DOCKER_USERNAME} -e DOCKER_PASSWORD=${DOCKER_PASSWORD} -e PLUGIN_REPO=banzaicloud/drone-kaniko-test -e PLUGIN_TAGS=test -e PLUGIN_DOCKERFILE=Dockerfile.test banzaicloud/drone-kaniko
-```
-
-The very same example just pushing to GCR instead of Docker Hub:
-
-```bash
-docker run --net=host -it --rm -w /src -v $PWD:/cache -v $PWD:/src -e PLUGIN_REGISTRY=gcr.io -e PLUGIN_REPO=paas-dev1/drone-kaniko-test -e PLUGIN_TAGS=test -e PLUGIN_DOCKERFILE=Dockerfile.test -e PLUGIN_CACHE=true -e PLUGIN_JSON_KEY="$(<$HOME/google-application-credentials.json)" banzaicloud/drone-kaniko
 ```

plugin.sh

@@ -4,12 +4,11 @@ set -euo pipefail
 
 export PATH=$PATH:/kaniko/
 
-REGISTRY=${PLUGIN_REGISTRY:-index.docker.io}
+DOCKER_AUTH=`echo -n "${PLUGIN_USERNAME}:${PLUGIN_PASSWORD}" | base64 | tr -d "\n"`
 
-if [ "${PLUGIN_USERNAME:-}" ] || [ "${PLUGIN_PASSWORD:-}" ]; then
+REGISTRY=${PLUGIN_REGISTRY:-https://index.docker.io/v1/}
-    DOCKER_AUTH=`echo -n "${PLUGIN_USERNAME}:${PLUGIN_PASSWORD}" | base64 | tr -d "\n"`
 
-    cat > /kaniko/.docker/config.json <<DOCKERJSON
+cat > /kaniko/.docker/config.json <<DOCKERJSON
 {
     "auths": {
         "${REGISTRY}": {
@@ -18,92 +17,33 @@ if [ "${PLUGIN_USERNAME:-}" ] || [ "${PLUGIN_PASSWORD:-}" ]; then
     }
 }
 DOCKERJSON
-fi
-
-if [ "${PLUGIN_JSON_KEY:-}" ];then
-    echo "${PLUGIN_JSON_KEY}" > /kaniko/gcr.json
-    export GOOGLE_APPLICATION_CREDENTIALS=/kaniko/gcr.json
-fi
 
 DOCKERFILE=${PLUGIN_DOCKERFILE:-Dockerfile}
 CONTEXT=${PLUGIN_CONTEXT:-$PWD}
 LOG=${PLUGIN_LOG:-info}
-EXTRA_OPTS=""
 
 if [[ -n "${PLUGIN_TARGET:-}" ]]; then
     TARGET="--target=${PLUGIN_TARGET}"
 fi
 
-if [[ "${PLUGIN_SKIP_TLS_VERIFY:-}" == "true" ]]; then
-    EXTRA_OPTS="--skip-tls-verify=true"
-fi
-
 if [[ "${PLUGIN_CACHE:-}" == "true" ]]; then
     CACHE="--cache=true"
 fi
 
-if [ -n "${PLUGIN_CACHE_REPO:-}" ]; then
+if [[ -n "${PLUGIN_BUILD_ARGS:-}" ]]; then
-    CACHE_REPO="--cache-repo=${REGISTRY}/${PLUGIN_CACHE_REPO}"
-fi
-
-if [ -n "${PLUGIN_CACHE_TTL:-}" ]; then
-    CACHE_TTL="--cache-ttl=${PLUGIN_CACHE_TTL}"
-fi
-
-if [ -n "${PLUGIN_BUILD_ARGS:-}" ]; then
     BUILD_ARGS=$(echo "${PLUGIN_BUILD_ARGS}" | tr ',' '\n' | while read build_arg; do echo "--build-arg=${build_arg}"; done)
 fi
 
-if [ -n "${PLUGIN_BUILD_ARGS_FROM_ENV:-}" ]; then
+if [[ -n "${PLUGIN_TAGS:-}" ]]; then
-    BUILD_ARGS_FROM_ENV=$(echo "${PLUGIN_BUILD_ARGS_FROM_ENV}" | tr ',' '\n' | while read build_arg; do echo "--build-arg ${build_arg}=$(eval "echo \$$build_arg")"; done)
+    DESTINATIONS=$(echo "${PLUGIN_TAGS}" | tr ',' '\n' | while read tag; do echo "--destination=${PLUGIN_REPO}:${tag} "; done)
-fi
-
-# auto_tag, if set auto_tag: true, auto generate .tags file
-# support format Major.Minor.Release or start with `v`
-# docker tags: Major, Major.Minor, Major.Minor.Release and latest
-if [[ "${PLUGIN_AUTO_TAG:-}" == "true" ]]; then
-    TAG=$(echo "${DRONE_TAG:-}" |sed 's/^v//g')
-    part=$(echo "${TAG}" |tr '.' '\n' |wc -l)
-    # expect number
-    echo ${TAG} |grep -E "[a-z-]" &>/dev/null && isNum=1 || isNum=0
-
-    if [ ! -n "${TAG:-}" ];then
-        echo "latest" > .tags
-    elif [ ${isNum} -eq 1 -o ${part} -gt 3 ];then
-        echo "${TAG},latest" > .tags
-    else
-        major=$(echo "${TAG}" |awk -F'.' '{print $1}')
-        minor=$(echo "${TAG}" |awk -F'.' '{print $2}')
-        release=$(echo "${TAG}" |awk -F'.' '{print $3}')
-    
-        major=${major:-0}
-        minor=${minor:-0}
-        release=${release:-0}
-    
-        echo "${major},${major}.${minor},${major}.${minor}.${release},latest" > .tags
-    fi  
-fi
-
-if [ -n "${PLUGIN_TAGS:-}" ]; then
-    DESTINATIONS=$(echo "${PLUGIN_TAGS}" | tr ',' '\n' | while read tag; do echo "--destination=${REGISTRY}/${PLUGIN_REPO}:${tag} "; done)
-elif [ -f .tags ]; then
-    DESTINATIONS=$(cat .tags| tr ',' '\n' | while read tag; do echo "--destination=${REGISTRY}/${PLUGIN_REPO}:${tag} "; done)
-elif [ -n "${PLUGIN_REPO:-}" ]; then
-    DESTINATIONS="--destination=${REGISTRY}/${PLUGIN_REPO}:latest"
 else
-    DESTINATIONS="--no-push"
+    DESTINATIONS="--destination=${PLUGIN_REPO}:latest"
-    # Cache is not valid with --no-push
-    CACHE=""
 fi
 
 /kaniko/executor -v ${LOG} \
     --context=${CONTEXT} \
     --dockerfile=${DOCKERFILE} \
-    ${EXTRA_OPTS} \
     ${DESTINATIONS} \
     ${CACHE:-} \
-    ${CACHE_TTL:-} \
-    ${CACHE_REPO:-} \
     ${TARGET:-} \
-    ${BUILD_ARGS:-} \
+    ${BUILD_ARGS:-}
-    ${BUILD_ARGS_FROM_ENV:-}