From 9b3d4cfd8b645002e3d9a3a623ef749cb7ff0298 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torma=20Krist=C3=B3f?= <tormakristof@tormakristof.eu>
Date: Tue, 29 Oct 2019 11:16:37 +0100
Subject: [PATCH] minor problems fixed

---
 deploy/install_helm.sh                           | 1 +
 deploy/install_knative.sh                        | 7 ++++++-
 deploy/kubeless_setup.sh                         | 4 ++--
 functions/scaling/hello-world-go-concurrency.yml | 4 ++--
 4 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/deploy/install_helm.sh b/deploy/install_helm.sh
index bca0826..e34dfda 100644
--- a/deploy/install_helm.sh
+++ b/deploy/install_helm.sh
@@ -1,6 +1,7 @@
 #!/bin/bash
 
 #Install helm using snap
+apt install -y snapd
 snap install helm --classic
 
 #Init helm with an admin tiller pod.
diff --git a/deploy/install_knative.sh b/deploy/install_knative.sh
index 5f2421c..fe571a5 100644
--- a/deploy/install_knative.sh
+++ b/deploy/install_knative.sh
@@ -1,7 +1,7 @@
 #!/bin/bash 
 
 #Download and unpack istio
-ISTIO_VERSION=1.3.1
+ISTIO_VERSION=1.4.0-beta0
 curl -L https://git.io/getLatestIstio | sh -
 cd istio-${ISTIO_VERSION}
 
@@ -39,5 +39,10 @@ kubectl apply --selector knative.dev/crd-install=true \
 --filename https://github.com/knative/serving/releases/download/v0.9.0/serving.yaml \
 --filename https://github.com/knative/eventing/releases/download/v0.9.0/release.yaml
 
+#This is needed because some CRDs do get installed properly
+kubectl apply --selector knative.dev/crd-install=true \
+--filename https://github.com/knative/serving/releases/download/v0.9.0/serving.yaml \
+--filename https://github.com/knative/eventing/releases/download/v0.9.0/release.yaml
+
 kubectl apply --filename https://github.com/knative/serving/releases/download/v0.9.0/serving.yaml \
 --filename https://github.com/knative/eventing/releases/download/v0.9.0/release.yaml
diff --git a/deploy/kubeless_setup.sh b/deploy/kubeless_setup.sh
index 43943d0..f5b1ad0 100644
--- a/deploy/kubeless_setup.sh
+++ b/deploy/kubeless_setup.sh
@@ -20,5 +20,5 @@ curl -OL https://github.com/kubeless/kubeless/releases/download/$RELEASE/kubeles
   sudo mv bundles/kubeless_$OS-amd64/kubeless /usr/local/bin/
 
 #Ingress nginx
-kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/mandatory.yaml
-kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/provider/baremetal/service-nodeport.yaml
+kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/mandatory.yaml
+kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/provider/baremetal/service-nodeport.yaml
diff --git a/functions/scaling/hello-world-go-concurrency.yml b/functions/scaling/hello-world-go-concurrency.yml
index fb8b644..8819508 100644
--- a/functions/scaling/hello-world-go-concurrency.yml
+++ b/functions/scaling/hello-world-go-concurrency.yml
@@ -1,7 +1,7 @@
 apiVersion: serving.knative.dev/v1alpha1
 kind: Service
 metadata:
-  name: helloworld-py-sc-cc
+  name: helloworld-go-sc-cc
   namespace: default
 spec:
   template:
@@ -18,7 +18,7 @@ spec:
         autoscaling.knative.dev/maxScale: "100"
     spec:
       containers:
-        - image: tormachris/hello-world-py
+        - image: tormachris/hello-world-go
           env:
             - name: TARGET
               value: "Go"