tormakris/cf-workers-status-page
1
0
Fork 0
mirror of https://github.com/tormachris/cf-workers-status-page.git synced 2024-11-23 14:45:41 +01:00
Code Releases Activity

Merge pull request #2 from eidam/e/gh-actions-default-secret

Browse Source 
fix(actions): let deployment pass on missing slack webhook
This commit is contained in:
Adam Janiš 2020-11-14 17:32:36 +01:00 committed by GitHub
commit dc347e083f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/deploy.yml vendored
View File

@ -27,6 +27,7 @@ jobs:
kv_namespace_id=$(wrangler kv:namespace list | jq -c 'map(select(.title | contains("KV_STATUS_PAGE")))' | jq ".[0].id")
echo "[env.production]" >> wrangler.toml
echo "kv_namespaces = [{binding=\"KV_STATUS_PAGE\", id=${kv_namespace_id}}]" >> wrangler.toml
[ -z "$SECRET_SLACK_WEBHOOK_URL" ] && echo "Secret SECRET_SLACK_WEBHOOK_URL not set, creating dummy one..." && SECRET_SLACK_WEBHOOK_URL="default-gh-action-secret" || true
secrets: |
SECRET_SLACK_WEBHOOK_URL
environment: production

2
src/functions/cronTrigger.js
View File

@ -42,7 +42,7 @@ export async function processCronTrigger(event) {
console.log('Saving changed state..')
// first try to notify Slack in case fetch() or other limit is reached
if (typeof SECRET_SLACK_WEBHOOK_URL !== 'undefined') {
if (typeof SECRET_SLACK_WEBHOOK_URL !== 'undefined' && SECRET_SLACK_WEBHOOK_URL !== 'default-gh-action-secret') {
await notifySlack(monitor, newMetadata)
}